fix: incorrect updateWithStart signature#594
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
roxblnfk
left a comment
There was a problem hiding this comment.
Sorry, I didn't notice that my review was in pending status.
| * @see WorkflowClientCallsInterceptor::updateWithStart() | ||
| */ | ||
| public function updateWithStart(UpdateWithStartInput $input, callable $next): UpdateHandle | ||
| public function updateWithStart(UpdateWithStartInput $input, callable $next): array |
There was a problem hiding this comment.
Could you replace the array with UpdateWithStartOutput DTO?
There was a problem hiding this comment.
Sure, hopefully managed to cover all the relevant places for it.
Also that exception returning makes things messy, considered making separate properties for $handle and $exception, but then we would have nullable values and ugly checks for those
c385a5f to
9e7cbe7
Compare
What was changed
WorkflowClientCallsInterceptor::updateWithStart()signature to match value returned fromWorkflowStarter::updateWithStart()Why?
Because whenever
WorkflowClientCallsInterceptorimplementation is provided andupdateWithStart()is called exception happens.Example output, from the provided test case, if signature change is reverted
Checklist
Closes nothing (did not find any related issue)
How was this tested:
See the added test case
Any docs updates needed?
No