Skip to content

Null coalesce in AttributeMapper instead of try/catch#615

Merged
roxblnfk merged 1 commit into
temporalio:masterfrom
shanginn:null-coalesce-instead-of-try-catch-in-marshaller
May 12, 2025
Merged

Null coalesce in AttributeMapper instead of try/catch#615
roxblnfk merged 1 commit into
temporalio:masterfrom
shanginn:null-coalesce-instead-of-try-catch-in-marshaller

Conversation

@shanginn

Copy link
Copy Markdown
Contributor

This PR related to the discord discussion about a bug where error handler can be reassigned so this error is not being caught.

null-coalesce will serve the same purpose here and will not rely on try/catch

…mplify error handling by using null coalescing instead of try-catch blocks. This improves code readability and maintains functionality.
@shanginn shanginn requested a review from wolfy-j as a code owner May 11, 2025 09:26
@vercel

vercel Bot commented May 11, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 9:27am

@roxblnfk roxblnfk merged commit e60c9e3 into temporalio:master May 12, 2025
@roxblnfk roxblnfk added this to the 2.15.0 milestone Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants