New Worker Versioning API #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options as an array callable
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…flow versioning support
…on instead of string
refactor: move versioning DTOs into common folder;
# Conflicts: # src/Internal/Workflow/Process/Process.php
wolfy-j
approved these changes
Sep 12, 2025
Sushisource
reviewed
Sep 17, 2025
| sleep(5); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We should have a test to verify that, if the user enables worker versioning and does not specify a default, we complain if they register any workflow without a specified behavior. IE: All workflows must have a versioning behavior when versioning is enabled, either via the default or explicit.
Collaborator
Author
There was a problem hiding this comment.
It seems that GoSDK on the RoadRunner side handles this task perfectly 😃
goroutine 1 [running]:
go.temporal.io/sdk/internal.(*AggregatedWorker).RegisterWorkflowWithOptions(0x0?, {0x7ff793c35e40?, 0xc00058e000?}, {{0xc0004e8e40?, 0x0?}, 0x0?, 0x0?})
go.temporal.io/[email protected]/internal/internal_worker.go:1191 +0x15e
github.com/temporalio/roadrunner-temporal/v5/aggregatedpool.TemporalWorkers(0xc00058e000, 0xc0003742a0, {0xc000169688, 0x4a, 0x7ff7940719c8?}, 0xc000701500, {0x1e87dadd400, 0xc0005ae400}, 0xc0004490e0)
github.com/temporalio/roadrunner-temporal/[email protected]/aggregatedpool/workers.go:48 +0xa15
github.com/temporalio/roadrunner-temporal/v5.(*Plugin).initPool(0xc000243ce0)
github.com/temporalio/roadrunner-temporal/[email protected]/internal.go:93 +0x785
github.com/temporalio/roadrunner-temporal/v5.(*Plugin).Serve(0xc000243ce0)
github.com/temporalio/roadrunner-temporal/[email protected]/plugin.go:176 +0x98
reflect.Value.call({0xc00013d1d0?, 0xc0000e6830?, 0x1e87c690108?}, {0x7ff793cf3c82, 0x4}, {0xc0004b0858, 0x1, 0xc000539728?})
reflect/value.go:581 +0xcc6
reflect.Value.Call({0xc00013d1d0?, 0xc0000e6830?, 0x0?}, {0xc0004b0858?, 0x1?, 0x1?})
reflect/value.go:365 +0xb9
github.com/roadrunner-server/endure/v2.(*Endure).serve(0xc00013c730)
github.com/roadrunner-server/endure/[email protected]/serve.go:44 +0x565
github.com/roadrunner-server/endure/v2.(*Endure).Serve(0xc00013c730)
github.com/roadrunner-server/endure/[email protected]/endure.go:208 +0xa8
github.com/roadrunner-server/roadrunner/v2025/internal/cli.NewCommand.NewCommand.func3(0xc0004d8600?, {0x7ff793cf3be6?, 0x4?, 0x7ff793cf3bea?})
github.com/roadrunner-server/roadrunner/v2025/internal/cli/serve/command.go:74 +0x58c
github.com/spf13/cobra.(*Command).execute(0xc00012cc08, {0xc00014db00, 0x8, 0x8})
github.com/spf13/[email protected]/command.go:1015 +0xb02
github.com/spf13/cobra.(*Command).ExecuteC(0xc00012c308)
github.com/spf13/[email protected]/command.go:1148 +0x465
github.com/spf13/cobra.(*Command).Execute(0xc00004c2d8?)
github.com/spf13/[email protected]/command.go:1071 +0x13
main.run()
github.com/roadrunner-server/roadrunner/v2025/cmd/rr/main.go:26 +0x45
main.main()
github.com/roadrunner-server/roadrunner/v2025/cmd/rr/main.go:16 +0x13
1 task
Sushisource
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
WorkflowVersioningBehaviorattributeCommon docs:
https://docs.temporal.io/production-deployment/worker-deployments/worker-versioning
Checklist