Control Abandoned Child Workflow Cancellation #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
FeatureFlags::$cancelAbandonedChildWorkflowsinsrc/Worker/FeatureFlags.phpChildWorkflowStub.phpto check the feature flag when determining if child workflows should be cancellableRuntimeBuilder.phpto use the new feature flagCancelAbandonTest.phpwith multiple scenariosWhy?
Previously, when a parent workflow was canceled, all child workflows would be canceled, including those with
ParentClosePolicy::Abandon. This behavior was incorrect according to Temporal semantics - abandoned child workflows should continue running independently when their parent is canceled.The feature flag provides:
trueto maintain existing behaviorfalseThis change ensures that abandoned child workflows behave correctly while allowing existing workflows to continue functioning without breaking changes.
Checklist