Skip to content

feat: add test runner wrapper to handle windows non-zero exit codes #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xepozz merged 9 commits into from
Jan 29, 2026
Merged

feat: add test runner wrapper to handle windows non-zero exit codes #707

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
df00dd9
fix: upgrade symfony/process lowest version to 5.4.51
xepozz Jan 29, 2026
d4f381e
test: handle non-zero exit codes when tests succeed
xepozz Jan 29, 2026
47d5107
test: add test runner
xepozz Jan 29, 2026
414cc4f
test: windows suitable path
xepozz Jan 29, 2026
850e016
test: pass php exucutable
xepozz Jan 29, 2026
6ca7592
test: fix xml element access
xepozz Jan 29, 2026
ff10ea9
test: use PHP_BINARY for passing php executable to passthru command
xepozz Jan 29, 2026
8398d2d
test: rename file, add shebang
xepozz Jan 29, 2026
f6da77a
Merge branch 'master' into handle-exit-codes
xepozz Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"symfony/filesystem": "^5.4.45 || ^6.4.13 || ^7.0 || ^8.0",
"symfony/http-client": "^5.4.49 || ^6.4.17 || ^7.0 || ^8.0",
"symfony/polyfill-php83": "^1.31.0",
"symfony/process": "^5.4.47 || ^6.4.15 || ^7.0 || ^8.0"
"symfony/process": "^5.4.51 || ^6.4.15 || ^7.0 || ^8.0"
},
"autoload": {
"psr-4": {
Expand All @@ -56,6 +56,7 @@
]
},
"require-dev": {
"ext-simplexml": "*",
"buggregator/trap": "^1.13.0",
"composer/composer": "^2.8.4",
"cweagans/composer-patches": "^2.0",
Expand Down Expand Up @@ -98,10 +99,10 @@
"cs:fix": "php-cs-fixer fix -v",
"psalm": "psalm",
"psalm:baseline": "psalm --set-baseline=psalm-baseline.xml",
"test:unit": "phpunit --testsuite=Unit --color=always --testdox",
"test:func": "phpunit --testsuite=Functional --color=always --testdox",
"test:unit": "php tests/ci-runner.php vendor/bin/phpunit --testsuite=Unit --color=always --testdox",
"test:func": "php tests/ci-runner.php vendor/bin/phpunit --testsuite=Functional --color=always --testdox",
Comment thread
roxblnfk marked this conversation as resolved.
Outdated
"test:arch": "phpunit --testsuite=Arch --color=always --testdox",
"test:accept": "phpunit --testsuite=Acceptance --color=always --testdox"
"test:accept": "php tests/ci-runner.php vendor/bin/phpunit --testsuite=Acceptance --color=always --testdox"
},
"config": {
"sort-packages": true,
Expand Down
24 changes: 24 additions & 0 deletions tests/ci-runner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php

declare(strict_types=1);

/**
* Sometimes Windows CI runner fails to report test results properly.
* This script is a workaround for that.
*/

$command = \implode(' ', \array_slice($argv, 1));
$logFile = 'runtime/phpunit.xml';

\passthru("php $command --log-junit=$logFile 2>&1", $code);
Comment thread
xepozz marked this conversation as resolved.
Outdated

if (\file_exists($logFile)) {
$xml = \simplexml_load_file($logFile);
$failures = (int) $xml['failures'] + (int) $xml['errors'];

if ($failures === 0) {
exit(0);
}
}

exit($code ?: 1);
Loading