Skip to content

test: use ip address instead of localhost#713

Merged
xepozz merged 2 commits into
masterfrom
ip-1
Feb 22, 2026
Merged

test: use ip address instead of localhost#713
xepozz merged 2 commits into
masterfrom
ip-1

Conversation

@xepozz

@xepozz xepozz commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

What was changed

Changed localhost to 127.0.0.1

Why?

DNS resolving isn't a thing we want to have during tests. Also, sometimes it stuck for some reasons and tests fail because of it.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@xepozz xepozz requested a review from wolfy-j as a code owner February 21, 2026 07:53
@vercel

vercel Bot commented Feb 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
php Ready Ready Preview, Comment Feb 22, 2026 0:25am

Request Review

@semgrep-managed-scans

Copy link
Copy Markdown

Semgrep found 1 missing-explicit-permissions finding:

No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).

@xepozz xepozz merged commit 45e0d61 into master Feb 22, 2026
281 of 284 checks passed
@xepozz xepozz deleted the ip-1 branch February 22, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants