Add handling for datetimes to the default Json Converter #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
changed the title
cretz
reviewed
May 16, 2025
There was a problem hiding this comment.
I think we also have to update the README that we support datetime now. I do wonder whether we want to support date and time, but maybe not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add handling for datetimes to the default Json Converter
Why?
datetimes are a common payload to need to serialize
Checklist
Closes [Feature Request] Support serialization of
datetimevalues in default JSON converter #627How was this tested:
New unit tests
Any docs updates needed?