[Feature Request] Time#iso8601 improperly considered illegal, look into excluding

[cretz]

Describe the solution you'd like

A user calling Time#iso8601 is getting a trace with:

/usr/local/bundle/ruby/3.3.0/gems/temporalio-0.4.0-aarch64-linux/lib/temporalio/internal/worker/workflow_instance/illegal_call_tracer.rb:66:in `block in initialize'                                                                
/usr/local/lib/ruby/3.3.0/time.rb:82:in `zone_offset'
/usr/local/lib/ruby/3.3.0/time.rb:640:in `xmlschema'

This is because the second parameter at https://github.com/ruby/ruby/blob/5124f9ac7513eb590c37717337c430cb93caa151/lib/time.rb#L82 is asking for current time. Ug. We need to find some way to exclude this.

Right now we only accept a basic hash of illegal calls. We probably need a more advanced abstraction for illegal time skipping that allows a workflow-stateful stack to skip checking further down. Put it behind a very generic "check illegal" abstract class so others can have implementations.

[igillis-clara]

Ideally it could be judicious about initialize as well. If it's called with arguments and a timezone, I don't believe there is any nondeterminism issue. This comes up when trying to deserialize datetime strings using the default ActiveModel deserialization.

https://github.com/rails/rails/blob/v7.1.5.1/activemodel/lib/active_model/type/helpers/time_value.rb#L76

https://github.com/ruby/ruby/blob/v3_3_8/timev.rb#L409

[cretz]

👍 Yes, we need to support Time#initialize with deterministic parameters. It's a little wonky with TracePoint to do something that advanced (inspect parameters via binding), but it can be done and we will have tests confirming it.