More client features #157
More client features #157
Conversation
dandavison
left a comment
dandavison
left a comment
There was a problem hiding this comment.
I'm approving this. Obviously it's a lot of code, mostly scaffolding, and hard to review in a thorough sense. I've looked through, and learned a few things, and it all looks great and carefully done. I don't think there's a need at this early stage of the project to block merging this on careful review by others.
.github/workflows/ci.yml
Outdated
| working-directory: ./temporalio | ||
| run: | | ||
| bundle exec rake proto:generate | ||
| [[ -z $(git status --porcelain lib/temporalio/api) ]] || (git diff lib/temporalio/api; echo "Protos changed"; exit 1) |
There was a problem hiding this comment.
| [[ -z $(git status --porcelain lib/temporalio/api) ]] || (git diff lib/temporalio/api; echo "Protos changed"; exit 1) | |
| [[ -z $(git status --porcelain lib/temporalio/api) ]] || (git diff lib/temporalio/api; echo "Protos changed" 1>&2; exit 1) |
There was a problem hiding this comment.
This was taken from https://github.com/temporalio/sdk-python/blob/4aef4bfda19e56c7e7abac36b69e98f60861468c/.github/workflows/ci.yml#L95 so I wonder if we want to fix there too?
There was a problem hiding this comment.
Yep sounds good. Not urgent of course; could do it now or just do it next time one of us touches the CI yaml.
2 participants
What was changed