Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
build-lint-test:
strategy:
fail-fast: true
fail-fast: false
matrix:
# TODO(cretz): Enable Linux ARM. It's not natively supported with setup-ruby (see
# https://github.com/ruby/setup-ruby#supported-platforms and https://github.com/ruby/setup-ruby/issues/577).
Expand All @@ -24,7 +24,7 @@ jobs:
# https://github.com/temporalio/sdk-ruby/issues/172
os: [ubuntu-latest, macos-latest]
# Earliest and latest supported
rubyVersion: ["3.1", "3.3"]
rubyVersion: ["3.2", "3.3"]

include:
- os: ubuntu-latest
Expand Down Expand Up @@ -73,4 +73,6 @@ jobs:

- name: Lint, compile, test Ruby
working-directory: ./temporalio
# Timeout just in case there's a hanging part in rake
timeout-minutes: 20
run: bundle exec rake TESTOPTS="--verbose"
631 changes: 584 additions & 47 deletions README.md

Large diffs are not rendered by default.

9 changes: 7 additions & 2 deletions temporalio/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ Layout/LeadingCommentSpace:
# Don't need super for activities
Lint/MissingSuper:
AllowedParentClasses:
- Temporalio::Activity
- Temporalio::Activity::Definition
- Temporalio::Workflow::Definition

# Allow tests to nest methods
Lint/NestedMethodDefinition:
Expand Down Expand Up @@ -61,7 +62,7 @@ Metrics/ModuleLength:

# The default is too small
Metrics/PerceivedComplexity:
Max: 25
Max: 40

# We want classes to be documented
Style/Documentation:
Expand All @@ -80,6 +81,10 @@ Style/GlobalVars:
Exclude:
- test/**/*

# We're ok with two compound comparisons before doing Array.include?
Style/MultipleComparison:
ComparisonsThreshold: 3

# We want our require lists to be in order
Style/RequireOrder:
Enabled: true
Expand Down
2 changes: 2 additions & 0 deletions temporalio/.yardopts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
--readme README.md
--protected
2 changes: 1 addition & 1 deletion temporalio/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ group :development do
gem 'rbs', '~> 3.5.3'
gem 'rb_sys', '~> 0.9.63'
gem 'rubocop'
gem 'sqlite3', '~> 1.4'
gem 'sqlite3'
gem 'steep', '~> 1.7.1'
gem 'yard'
end
Loading
Loading