Workflow and activity instance access from context #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Jan 25, 2025
Comment on lines
+241
to
+242
| # Create the instance. We choose to do this before interceptors so that it is available in the interceptor. | ||
| activity.instance = defn.instance.is_a?(Proc) ? defn.instance.call : defn.instance # steep:ignore |
Member
There was a problem hiding this comment.
Could've done this by ensuring the first interceptor is always an interceptor that makes the instance
😉
Member
Author
There was a problem hiding this comment.
Not following this exactly. We originally had our interceptor make the instance, but that didn't provide the instance early enough for user interceptors. We don't have control over interceptor order to ensure any one is the first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Temporalio::Activity::Context#instanceto access the activity instanceTemporalio::Workflow.instanceto access the workflow instanceChecklist