Skip to content

User metadata #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2025
Merged

User metadata #223

merged 4 commits into from
Feb 20, 2025

Conversation

@cretz
Copy link
Member

@cretz cretz commented Feb 20, 2025

What was changed

  • Support static_summary and static_details on:
    • Temporalio::Client#start_workflow
    • Temporalio::Client#execute_workflow
    • Temporalio::Client::WithStartWorkflowOperation#initialize
    • Temporalio::Client::Schedule::Action::StartWorkflow#initialize
    • Temporalio::Client::WorkflowExecution::Description
  • Support summary on:
    • Temporalio::Workflow.sleep (and Temporalio::Workflow.timeout by extension)
    • Temporalio::Workflow.execute_activity
    • Temporalio::Workflow.start_child_workflow
    • Temporalio::Workflow.execute_child_workflow
  • Support description on:
    • Temporalio::Workflow::Definition.workflow_query_attr_reader
    • Temporalio::Workflow::Definition.workflow_signal and Temporalio::Workflow::Definition::Signal
    • Temporalio::Workflow::Definition.workflow_query and Temporalio::Workflow::Definition::Query
    • Temporalio::Workflow::Definition.workflow_update and Temporalio::Workflow::Definition::Update
  • Support Temporalio::Workflow.current_details get/set
  • Support __temporal_workflow_metadata query
  • Interceptors for all where applicable
  • Tests for all

Checklist

  1. Closes [Feature Request] Support user metadata #217

@cretz cretz requested a review from a team February 20, 2025 14:20
cretz
cretz commented Feb 20, 2025
View reviewed changes
temporalio/test/worker_workflow_handler_test.rb
end
end

def test_update_with_start_start_fail
Copy link
Member Author

@cretz cretz Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, just added here because was missed in original update-with-start PR

Sushisource
Sushisource approved these changes Feb 20, 2025
View reviewed changes
@cretz cretz merged commit 5d692ab into temporalio:main Feb 20, 2025
6 checks passed
@cretz cretz deleted the user-metadata branch February 20, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support user metadata

2 participants

@cretz @Sushisource