Skip to content

Use RawValue for built-in query response #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Use RawValue for built-in query response #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5fc75b
Use RawValue for built-in query response
cretz Mar 7, 2025
191d852
Merge branch 'main' into raw-value-built-in-query
cretz Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions temporalio/lib/temporalio/internal/worker/workflow_instance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
require 'temporalio'
require 'temporalio/activity/definition'
require 'temporalio/api'
require 'temporalio/converters/payload_converter'
require 'temporalio/converters/raw_value'
require 'temporalio/error'
require 'temporalio/internal/bridge/api'
Expand Down Expand Up @@ -388,9 +389,11 @@ def apply_query(job)
schedule do
# If it's a built-in, run it without interceptors, otherwise do normal behavior
result = if job.query_type == '__stack_trace'
scheduler.stack_trace
# Use raw value built from default converter because we don't want to use user-conversion
Converters::RawValue.new(Converters::PayloadConverter.default.to_payload(scheduler.stack_trace))
elsif job.query_type == '__temporal_workflow_metadata'
workflow_metadata
# Use raw value built from default converter because we don't want to use user-conversion
Converters::RawValue.new(Converters::PayloadConverter.default.to_payload(workflow_metadata))
else
# Get query definition, falling back to dynamic if not present and not reserved
defn = query_handlers[job.query_type]
Expand Down
Loading