Skip to content

Support unsafe IO/io_wait inside workflows #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Support unsafe IO/io_wait inside workflows #243

merged 2 commits into from
Apr 15, 2025

Conversation

@cretz
Copy link
Member

@cretz cretz commented Apr 10, 2025

What was changed

  • Added Temporalio::Workflow::Unsafe.io_enabled that accepts a block to have IO enabled for
  • Added unsafe_workflow_io_enabled default-false bool option for workers/replayers
  • Implemented Fiber::Scheduler#io_wait to fail with clear message if not enabled, or work via blocking IO when enabled

Checklist

  1. Closes [Feature Request] Allow use of io_wait-based fiber calls #239

@cretz cretz requested a review from a team April 10, 2025 15:28
@cretz cretz merged commit 90d90bd into temporalio:main Apr 15, 2025
7 checks passed
@cretz cretz deleted the workflow-io-support branch August 18, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow use of io_wait-based fiber calls

2 participants

@cretz @Sushisource