-
Notifications
You must be signed in to change notification settings - Fork 22
Fix auto_time_skipping_disabled #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auto_time_skipping_disabled #260
Conversation
| return super unless supports_time_skipping? | ||
|
|
||
| already_disabled = @auto_time_skipping | ||
| already_disabled = !@auto_time_skipping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think our logic at https://github.com/temporalio/sdk-dotnet/blob/d48377d698b2a2cb7a8c58d181959df473875314/src/Temporalio/Testing/WorkflowEnvironment.cs#L323-L338 is wrong (and https://github.com/temporalio/sdk-python/blob/e3603989f081bb812d883189be5f5ac9aa127089/temporalio/testing/_workflow.py#L464-L472 is right), so time to fix .NET too heh.
|
Can you sign the CLA (via link above) so we can merge? Or let me know if already signed and it's not updating. |
|
Signed |
| end | ||
|
|
||
| def test_auto_time_skipping_disabled | ||
| skip_if_not_x86! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this line is required -- seemed to run fine on my apple silicon Mac 🤷 but left it for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yeah it runs in macos due to rosetta x64 translator, but technically we don't support time-skipping on ARM (though it was added recently, we just have to update the auto downloader).
Checklist
Closes [Bug] auto_time_skipping_disabled not resuming after block exit #259
How was this tested:
Failing Before Fix

Passing After Fix

An example using this helper would be nice but probably out of scope for this PR