Skip to content

Conversation

@igillis-clara
Copy link
Contributor

Checklist

  1. Closes [Bug] auto_time_skipping_disabled not resuming after block exit #259

  2. How was this tested:

  • Made the change locally and it fixed the test I was writing in my application
  • Wrote a test for this PR

Failing Before Fix
CleanShot 2025-05-02 at 16 14 02@2x

Passing After Fix
CleanShot 2025-05-02 at 16 14 45@2x

  1. Any docs updates needed?
    An example using this helper would be nice but probably out of scope for this PR

@igillis-clara igillis-clara requested a review from a team as a code owner May 2, 2025 20:33
@CLAassistant
Copy link

CLAassistant commented May 2, 2025

CLA assistant check
All committers have signed the CLA.

return super unless supports_time_skipping?

already_disabled = @auto_time_skipping
already_disabled = !@auto_time_skipping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cretz
Copy link
Member

cretz commented May 2, 2025

Can you sign the CLA (via link above) so we can merge? Or let me know if already signed and it's not updating.

@igillis-clara
Copy link
Contributor Author

Signed

end

def test_auto_time_skipping_disabled
skip_if_not_x86!
Copy link
Contributor Author

@igillis-clara igillis-clara May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this line is required -- seemed to run fine on my apple silicon Mac 🤷 but left it for consistency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah it runs in macos due to rosetta x64 translator, but technically we don't support time-skipping on ARM (though it was added recently, we just have to update the auto downloader).

@cretz cretz merged commit 9ce9025 into temporalio:main May 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] auto_time_skipping_disabled not resuming after block exit

3 participants