Add workflow check that local activity exists #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
force-pushed
the
missing_local_activity
branch
from
18a2a86 to
3e7249e
Compare
cretz
approved these changes
May 12, 2025
Member
There was a problem hiding this comment.
Looks great, thanks! Merge at will after CI. I saw there is a CI flake at https://github.com/temporalio/sdk-ruby/actions/runs/14978028437/job/42075181750?pr=263. This is the first I've seen that, so I will be investigating it (but re-running for now). EDIT: Looks all good, merge at will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add workflow check that local activity exists
Why?
A missing local activity should fail the workflow task rather than the activity since it cannot succeed.
Checklist
Closes [Bug] Unregistered Local Activity should fail Workflow Task #253
How was this tested:
New workflow tests
Any docs updates needed?
None