Skip to content

Disallow keyword arguments on handlers with deserialized arguments #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Disallow keyword arguments on handlers with deserialized arguments #265

merged 2 commits into from
May 19, 2025

Conversation

@cretz
Copy link
Member

@cretz cretz commented May 12, 2025

What was changed

Disallow keyword arguments in activity, workflow execute, workflow init, workflow signal, workflow query, and workflow update (including validators)

Checklist

  1. Closes [Feature Request] Document and validate that keyword args are disallowed in certain contexts #226

@cretz cretz requested a review from a team as a code owner May 12, 2025 20:31
@cretz cretz merged commit f2e5c17 into temporalio:main May 19, 2025
7 checks passed
@cretz cretz deleted the disallow-kwargs branch May 19, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Document and validate that keyword args are disallowed in certain contexts

2 participants

@cretz @Sushisource