Skip to content

Allow unsafe disabling of durable workflow scheduler #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

Allow unsafe disabling of durable workflow scheduler #284

merged 2 commits into from
Jul 7, 2025

Conversation

@cretz
Copy link
Member

@cretz cretz commented Jun 10, 2025

What was changed

  • Added Temporalio::Workflow::Unsafe.durable_scheduler_disabled call that allows people to leave the durable fiber scheduler if they must
  • Update OTel interceptor to leave the durable fiber scheduler since it does some timer and IO things that we don't want to cause failure or be durable

Checklist

  1. Closes [Feature Request] Allow implicit durable timers to be disabled #251

@cretz cretz requested a review from a team as a code owner June 10, 2025 18:47
@cretz cretz merged commit dc83329 into temporalio:main Jul 7, 2025
7 checks passed
@cretz cretz deleted the disable-implicit-timers branch July 7, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow implicit durable timers to be disabled

2 participants

@cretz @Quinn-With-Two-Ns