Skip to content

Allow specifying Exception as workflow failure types #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

Allow specifying Exception as workflow failure types #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb9a0eb
Allow using 'Exception' in 'workflow_failure_exception_types'
jeromepl Jun 16, 2025
d788b00
Couple quick readme typo fixes
jeromepl Jun 16, 2025
71dd7fd
Merge branch 'main' into allow-specifying-exception-as-workflow-failu…
cretz Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,9 +1233,9 @@ First, install dependencies:

# Optional: Change bundler install path to be local
bundle config --local path $(pwd)/.bundle
bundle instal
bundle install

To build shared library for development use (ensure you have cloned submodules :
To build shared library for development use (ensure you have cloned submodules) :

bundle exec rake compile

Expand Down
2 changes: 1 addition & 1 deletion temporalio/lib/temporalio/internal/worker/workflow_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def initialize(
disable_eager_activity_execution:,
workflow_interceptors:,
workflow_failure_exception_types: workflow_failure_exception_types.map do |t|
unless t.is_a?(Class) && t < Exception
unless t.is_a?(Class) && t <= Exception
raise ArgumentError, 'All failure types must classes inheriting Exception'
end

Expand Down
2 changes: 1 addition & 1 deletion temporalio/lib/temporalio/workflow/definition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def workflow_raw_args(value = true) # rubocop:disable Style/OptionalBooleanParam
# @param types [Array<Class<Exception>>] Exception types to turn into workflow failures.
def workflow_failure_exception_type(*types)
types.each do |t|
raise ArgumentError, 'All types must classes inheriting Exception' unless t.is_a?(Class) && t < Exception
raise ArgumentError, 'All types must classes inheriting Exception' unless t.is_a?(Class) && t <= Exception
end
@workflow_failure_exception_types ||= []
@workflow_failure_exception_types.concat(types)
Expand Down
Loading