Skip to content

Update Core #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

Update Core #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
698b349
Update Core
cretz Aug 14, 2025
06b34f2
Rust formatting fix
cretz Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporalio/ext/sdk-core
Open in desktop
Submodule sdk-core updated 27 files
+2 −2 client/src/raw.rs
+8 −8 core-api/src/envconfig.rs
+7 −7 core-api/src/worker.rs
+6 −5 core-c-bridge/build.rs
+6 −6 core-c-bridge/src/runtime.rs
+2 −2 core-c-bridge/src/tests/context.rs
+37 −2 core/src/core_tests/mod.rs
+4 −2 core/src/lib.rs
+2 −4 core/src/test_help/mod.rs
+9 −5 core/src/worker/client.rs
+3 −1 core/src/worker/heartbeat.rs
+1 −3 core/src/worker/mod.rs
+58 −6 core/src/worker/workflow/history_update.rs
+30 −47 core/src/worker/workflow/machines/nexus_operation_state_machine.rs
+1 −1 core/src/worker/workflow/machines/upsert_search_attributes_state_machine.rs
+4 −1 core/src/worker/workflow/machines/workflow_machines.rs
+1 −1 core/src/worker/workflow/managed_run.rs
+4 −4 sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto
+9 −4 sdk-core-protos/src/history_builder.rs
+72 −0 sdk-core-protos/src/lib.rs
+1 −1 sdk/src/lib.rs
+8 −1 sdk/src/workflow_future.rs
+19 −25 tests/integ_tests/metrics_tests.rs
+19 −20 tests/integ_tests/queries_tests.rs
+1 −7 tests/integ_tests/update_tests.rs
+3 −5 tests/integ_tests/workflow_tests/local_activities.rs
+22 −17 tests/integ_tests/workflow_tests/nexus.rs
15 changes: 7 additions & 8 deletions temporalio/ext/src/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,14 +597,13 @@ fn build_tuner_resource_options<SK: SlotKind>(
.target_cpu_usage(options.member(id!("target_cpu_usage"))?)
.build()
.map_err(|err| error!("Failed building resource slot options: {}", err))?;
if let Some(prev_slots_options) = prev_slots_options {
if slots_options.target_cpu_usage != prev_slots_options.target_cpu_usage
|| slots_options.target_mem_usage != prev_slots_options.target_mem_usage
{
return Err(error!(
"All resource-based slot suppliers must have the same resource-based tuner options"
));
}
if let Some(prev_slots_options) = prev_slots_options
&& (slots_options.target_cpu_usage != prev_slots_options.target_cpu_usage
|| slots_options.target_mem_usage != prev_slots_options.target_mem_usage)
{
return Err(error!(
"All resource-based slot suppliers must have the same resource-based tuner options"
));
}
Ok((
SlotSupplierOptions::ResourceBased(ResourceSlotOptions::new(
Expand Down
2 changes: 1 addition & 1 deletion temporalio/lib/temporalio/api/payload_visitor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1493,7 +1493,7 @@ def coresdk_workflow_activation_resolve_nexus_operation(value)

def coresdk_workflow_activation_resolve_nexus_operation_start(value)
@on_enter&.call(value)
api_failure_v1_failure(value.cancelled_before_start) if value.has_cancelled_before_start?
api_failure_v1_failure(value.failed) if value.has_failed?
@on_exit&.call(value)
end

Expand Down
Loading
Loading