Fairness Keys & Weights #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Aug 20, 2025
| :priority_key | ||
| :priority_key, | ||
| :fairness_key, | ||
| :weight |
Member
There was a problem hiding this comment.
You called this fairness_weight in Python
Member
Author
There was a problem hiding this comment.
Yeah, dumb oversight
| # 3. The default weight of 1.0 will be used. | ||
| # | ||
| # Weight values are clamped to the range [0.001, 1000]. | ||
| class Priority |
Member
There was a problem hiding this comment.
So in Python you want priority_key to be provided on constructor, but have fairness_key and weight be optional? If so, you need to add an initialize in here that has the default params you want and calls super
| attr_reader weight: Float? | ||
|
|
||
| def initialize: (priority_key: Integer?) -> void | ||
| def initialize: (priority_key: Integer?, ?fairness_key: String?, ?weight: Float?) -> void |
Member
There was a problem hiding this comment.
Mentioned in other comment, but you'll need to write initialize if you want optional parameters (the default initialize of Data does not support default parameters, but it's easy to write yourself and call super)
cretz
approved these changes
Aug 20, 2025
|
|
||
| # Initialize a new Priority instance. | ||
| # | ||
| # @param priority_key [Integer] The priority key |
Member
There was a problem hiding this comment.
Suggested change
| # @param priority_key [Integer] The priority key | |
| # @param priority_key [Integer, nil] The priority key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added fairness keys/weights to priority
Why?
New feature
Checklist
Closes
How was this tested:
Added test
Any docs updates needed?