Fix tctl start workflow command with empty search attributes #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
approved these changes
Feb 22, 2021
| func processSearchAttr(c *cli.Context) *commonpb.SearchAttributes { | ||
| rawSearchAttrKey := c.String(FlagSearchAttributesKey) | ||
| searchAttrKeys := trimSpace(strings.Split(rawSearchAttrKey, searchAttrInputSeparator)) | ||
| sanitize := func(val string) []string { |
Contributor
There was a problem hiding this comment.
could be worth switching to multiple inputs in future, similar to here #600
Contributor
Author
There was a problem hiding this comment.
good point but not now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix
tctlstart workflowcommand with empty search attributes.Why?
W/o fix, start command treats empty search attributes list as list with one empty item, which is wrong and doesn't pass server validation.
How did you test it?
Run different combinations manually.
Potential risks
No risks.
Is hotfix candidate?
No.