Skip to content

Conversation

@alexshtin
Copy link
Contributor

What changed?
Type prefix was removed from enum values. Auto generated prefix is not used, which essentially just adds _ between type name and value name in code.

Why?
Enum values should not have type in them.

How did you test it?
Run all tests.

Potential risks
No risks.

@alexshtin alexshtin requested review from a team, mfateev, samarabbas and shawnhathaway April 4, 2020 19:44
@alexshtin alexshtin closed this Apr 4, 2020
@alexshtin alexshtin deleted the feature/remove-enum-prefix branch April 4, 2020 23:38
@alexshtin alexshtin restored the feature/remove-enum-prefix branch April 4, 2020 23:41
@alexshtin alexshtin reopened this Apr 4, 2020
@alexshtin alexshtin merged commit 34a5163 into temporalio:master Apr 4, 2020
@alexshtin alexshtin deleted the feature/remove-enum-prefix branch April 4, 2020 23:42
@alexshtin
Copy link
Contributor Author

Clicked wrong button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants