Skip to content

Support arbitrary history task category in SQL persistence #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Support arbitrary history task category in SQL persistence #3489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2c7b28
Support arbitrary history task category in SQL persistence
yycptt Oct 13, 2022
0f00037
fix license header
yycptt Oct 13, 2022
47fc609
fix tests
yycptt Oct 13, 2022
79ed14d
fix tests
yycptt Oct 13, 2022
2d35a44
add comments
yycptt Oct 19, 2022
1c6a997
Merge branch 'master' into sql-arbitrary-task-category
yycptt Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/persistence/cassandra/mutable_state_task_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ const (
`and workflow_id = ? ` +
`and run_id = ? ` +
`and visibility_ts = ? ` +
`and task_id > ? ` +
`and task_id <= ?`
`and task_id >= ? ` +
`and task_id < ?`
Comment on lines +79 to +80
Copy link
Member

@yiminc yiminc Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this safe?

Copy link
Member Author

@yycptt yycptt Oct 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is the correct behavior, all range queries are [inclusive, exclusive).
Didn't discovered this bug before as the code path is never exercised.

Currently we still don't have any queue using this code path (archival queue will be the first one), but at least there're persistence tests ensuring the correct behavior.


templateGetHistoryScheduledTasksQuery = `SELECT task_data, task_encoding ` +
`FROM executions ` +
Expand Down
Loading