Add sdk-features trigger to PRs #3627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
sdk-features-trigger
branch
4 times, most recently
from
2fb85ae to
85a48c6
Compare
yiminc
reviewed
Nov 19, 2022
Member
yiminc
left a comment
yiminc
left a comment
There was a problem hiding this comment.
Do we know how long does it take for these tests to run?
yiminc
reviewed
Nov 19, 2022
| needs: build-docker-image | ||
| uses: temporalio/sdk-features/.github/workflows/typescript.yaml@main | ||
| with: | ||
| version: 1.4.4 |
Member
There was a problem hiding this comment.
is there @latest release tag that we can use? so we don't have to update for every release
Member
Author
There was a problem hiding this comment.
We're going to add this to the sdk-features side.
Member
Author
There was a problem hiding this comment.
The typescript SDK version
Sushisource
force-pushed
the
sdk-features-trigger
branch
6 times, most recently
from
efaa6ab to
a945f53
Compare
Sushisource
force-pushed
the
sdk-features-trigger
branch
17 times, most recently
from
1c6ee5d to
c2ef8be
Compare
Sushisource
force-pushed
the
sdk-features-trigger
branch
7 times, most recently
from
023bb1f to
02ec5fa
Compare
Sushisource
force-pushed
the
sdk-features-trigger
branch
3 times, most recently
from
57b8193 to
d98264e
Compare
Sushisource
force-pushed
the
sdk-features-trigger
branch
from
d98264e to
d96ca07
Compare
mindaugasrukas
approved these changes
Dec 8, 2022
alexshtin
approved these changes
Dec 9, 2022
Sushisource
force-pushed
the
sdk-features-trigger
branch
2 times, most recently
from
dae7345 to
437f8ee
Compare
Member
Author
|
Will wait to merge this until we un-private the docker repo for sdk-features since it breaks forks. |
Sushisource
force-pushed
the
sdk-features-trigger
branch
from
437f8ee to
04bf1bb
Compare
Sushisource
force-pushed
the
sdk-features-trigger
branch
2 times, most recently
from
20f5c09 to
d795cc0
Compare
Sushisource
force-pushed
the
sdk-features-trigger
branch
from
d795cc0 to
0d82a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT while building
Add sdk-features coverage to PRs