Allows terminate of child even after continue as new #365
+640
−367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever child workflow is terminated due to Terminate policy specified by parent, history service compares both workflow and run id. This comparison won't cause child to be terminated if it does continue as new. Updated the transfer queue processor logic of workflow close processing to also include parent execution info when terminating all outstanding child executions. Updated history engine processing of Terminate to try and load current execution when terminate is triggered due to terminate policy of child and try to terminate the child if parent information matches.
mfateev
requested changes
May 11, 2020
mfateev
approved these changes
Aug 18, 2020
This was referenced Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added
FirstExecutionRunIdto request for Terminate and RequestCancel API. Client can pass inFirstExecutionRunIdto allow Terminate and RequestCancel across runs when workflow execution does continue as new.Updated the transfer queue processor logic of workflow close processing to also include
RunIdof started child workflow to allow terminate to work across runs of child execution.Updated history engine processing of Terminate and RequestCancel to also compare the
FirstExecutionIdpassed on the request with information in mutable state.Added
FirstExecutionRunIDto mutable state which gets persisted in DB. Now we don't rely on workflow execution started event for this information.Why?
Whenever child workflow is terminated due to Terminate policy specified by parent, history service compares both workflow and run Ids. This comparison won't cause child to be terminated if it does continue as new.
Fixes #364.
How did you test it?
Added new integration test:
TestChildWorkflowWithContinueAsNewParentTerminate.Potential risks
No risks.