Fix passing pointer of slice element in SQL query converter #3970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Feb 21, 2023
Member
yiminc
left a comment
yiminc
left a comment
There was a problem hiding this comment.
can we add test coverage for this
Contributor
Author
yiminc
approved these changes
Feb 21, 2023
rodrigozhou
force-pushed
the
fix-sql-qc-value-expr
branch
from
fbbd879 to
0087543
Compare
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Pass pointer of slice element when calling
convertValueExprso it's converted in-place.Why?
Query converter parses and changes expressions in-place, and all literal strings are expected to be converted to
unsafeSQLString.My previous PR #3950 refactoring the code broke tuple parsing.
How did you test it?
Writing unit tests.
Potential risks
No risks.
Is hotfix candidate?
Yes.