Support empty queries when listing archived workflows #4027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Mar 9, 2023
Contributor
|
What about gcloud and local fs? |
MichaelSnowden
force-pushed
the
snowden/s3-empty-query
branch
from
43b7a35 to
3873ab3
Compare
MichaelSnowden
changed the title
Contributor
Author
Added support for gcloud. It looks like local fs is already good. |
yycptt
reviewed
Mar 20, 2023
MichaelSnowden
force-pushed
the
snowden/s3-empty-query
branch
from
3873ab3 to
dfa788e
Compare
MichaelSnowden
changed the title
yycptt
reviewed
Mar 24, 2023
MichaelSnowden
force-pushed
the
snowden/s3-empty-query
branch
2 times, most recently
from
f99059b to
af4eca7
Compare
yycptt
approved these changes
Mar 24, 2023
MichaelSnowden
force-pushed
the
snowden/s3-empty-query
branch
from
af4eca7 to
1b2948f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now allow empty queries to the s3 visibility archival backend.
Why?
temporalio/ui#572
How did you test it?
I added unit tests for all of the different branches introduced. I also ran a manual end-to-end test verifying that this works for some locally archived workflows against my local stack instance. I verified that pagination works too:
Potential risks
It's fixing a page that is currently broken, so it can't do much more harm.
Is hotfix candidate?