Convert query converter error to invalid argument #4036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Mar 10, 2023
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
wxing1292
pushed a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Convert
query.ConverterErrortoserviceerror.InvalidArgument.Why?
Query converter error should be non-retryable as it's from an user input.
Converting the error to
serviceerror.InvalidArgumentdoes the trick.How did you test it?
Started local server, and tried submitting List request through temporal CLI with invalid query, and now it returns the error message from query converter instead of
context deadline exceededmessage.Potential risks
No risks.
Is hotfix candidate?
No.