Fix UnhandledCommand error for workflow task completion in CancelTimer #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `RequestCancelActivityTask` - `CancelTimer` - `CompleteWorkflowExecution`
yycptt
approved these changes
Mar 13, 2023
alexshtin
reviewed
Mar 14, 2023
| handler.hasBufferedEvents = handler.mutableState.HasBufferedEvents() | ||
| // In case the timer was cancelled and its TimerFired event was deleted from buffered events, attempt | ||
| // to unset hasBufferedEvents to allow the workflow to complete. | ||
| handler.hasBufferedEvents = handler.hasBufferedEvents && handler.mutableState.HasBufferedEvents() |
Contributor
There was a problem hiding this comment.
Suggested change
| handler.hasBufferedEvents = handler.hasBufferedEvents && handler.mutableState.HasBufferedEvents() | |
| if handler.hasBufferedEvents { | |
| handler.hasBufferedEvents = handler.mutableState.HasBufferedEvents() | |
| } |
please...
alexshtin
approved these changes
Mar 14, 2023
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
#4050) Fix UnhandledCommand error for workflow task completion with: - `RequestCancelActivityTask` - `CancelTimer` - `CompleteWorkflowExecution`
wxing1292
pushed a commit
that referenced
this pull request
Apr 14, 2023
#4050) Fix UnhandledCommand error for workflow task completion with: - `RequestCancelActivityTask` - `CancelTimer` - `CompleteWorkflowExecution`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix applies to this specific sequence of commands:
RequestCancelActivityTaskCancelTimerCompleteWorkflowExecutionCloses #4049