Use more reliable workflow mutation check #4076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
commented
Mar 22, 2023
| } | ||
|
|
||
| func (ms *MutableStateImpl) canReplicateEvents() bool { | ||
| return ms.namespaceEntry.ReplicationPolicy() == namespace.ReplicationPolicyMultiCluster |
Contributor
Author
There was a problem hiding this comment.
this assumption is broken
Contributor
Author
There was a problem hiding this comment.
what is the difference?
Contributor
There was a problem hiding this comment.
I think the name canReplicateEvents make sense as it return a boolean. But it is up to you.
wxing1292
commented
Mar 22, 2023
| ) error { | ||
|
|
||
| if transactionPolicy == TransactionPolicyPassive || | ||
| !ms.canReplicateEvents() { |
Contributor
Author
There was a problem hiding this comment.
this line is the real change
yux0
reviewed
Mar 22, 2023
| } | ||
|
|
||
| return ms.taskGenerator.GenerateUserTimerTasks() | ||
| func (ms *MutableStateImpl) generateReplicationTask() bool { |
Contributor
There was a problem hiding this comment.
This is the same as canReplicateEvents method.
| case TransactionPolicyPassive: | ||
| return nil | ||
| default: | ||
| panic(fmt.Sprintf("unknown transaction policy: %v", transactionPolicy)) |
Contributor
Author
There was a problem hiding this comment.
it is better to fail fast here, e.g. panic
i would consider return error when
- input validation fails
- modifying a complicated component & do not want to break production
there are only 2 policies here, no safety concern
| } | ||
|
|
||
| func (ms *MutableStateImpl) canReplicateEvents() bool { | ||
| return ms.namespaceEntry.ReplicationPolicy() == namespace.ReplicationPolicyMultiCluster |
yux0
approved these changes
Mar 22, 2023
hehaifengcn
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Make workflow mutation check more reliable Namespace migration breaks one of the assumption of XDC XDC assumes there will be no case which a namespace has only one cluster & the cluster is not itself, apparently namespace migration can break this assumption
wxing1292
added a commit
that referenced
this pull request
Mar 22, 2023
* Make workflow mutation check more reliable Namespace migration breaks one of the assumption of XDC XDC assumes there will be no case which a namespace has only one cluster & the cluster is not itself, apparently namespace migration can break this assumption
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
* Make workflow mutation check more reliable Namespace migration breaks one of the assumption of XDC XDC assumes there will be no case which a namespace has only one cluster & the cluster is not itself, apparently namespace migration can break this assumption
wxing1292
added a commit
that referenced
this pull request
Apr 14, 2023
* Make workflow mutation check more reliable Namespace migration breaks one of the assumption of XDC XDC assumes there will be no case which a namespace has only one cluster & the cluster is not itself, apparently namespace migration can break this assumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Namespace migration breaks one of the assumption of XDC
XDC assumes there will be no case which a namespace has only one cluster & the cluster is not itself, apparently namespace migration can break this assumption
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A