Account for local activity run time in schedule sleep #4079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Mar 23, 2023
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
yycptt
pushed a commit
that referenced
this pull request
Mar 24, 2023
wxing1292
pushed a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Calculate schedule sleep time right before sleeping, after local activities have been run.
Why?
The previous logic ignored the time taken by local activities, so it could end up sleeping too long. It's more accurate to calculate it later.
How did you test it?
existing unit & integration tests
Potential risks
Workflow determinism: we need to be careful to always set a positive sleep time whenever the previous logic did, since the SDK doesn't generate a timer for a negative or zero sleep time. There's logic to account for this, though it might have a bug.
Is hotfix candidate?
yes