Fix schedule catchup window metric calculation while paused #4152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samanbarghi
approved these changes
Apr 12, 2023
samanbarghi
pushed a commit
to samanbarghi/temporal
that referenced
this pull request
Apr 15, 2023
yycptt
pushed a commit
that referenced
this pull request
Apr 17, 2023
samanbarghi
pushed a commit
to samanbarghi/temporal
that referenced
this pull request
Apr 17, 2023
samanbarghi
pushed a commit
to samanbarghi/temporal
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Previously the workflow assumed that it would wake up at scheduled times while paused, but #3670 changed that, so now it might register "missed catchup window" when woken up after a pause. This fixes it to check paused first.
How did you test it?
unit test
Potential risks
This is technically not a deterministic change, but it only affects logging, metrics, and fields in the schedule Info, which are not used by the logic itself, only returned by a query, so it should be safe.