Fix adding multiple search attributes of same type at once #4273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
May 10, 2023
Member
yiminc
left a comment
yiminc
left a comment
There was a problem hiding this comment.
Could you add a unit test for this
alexshtin
approved these changes
May 10, 2023
|
|
||
| customSearchAttributes := currentSearchAttributes.Custom() | ||
| dbCustomSearchAttributes := searchattribute.GetSqlDbIndexSearchAttributes().CustomSearchAttributes | ||
| cmCustomSearchAttributes := currentSearchAttributes.Custom() |
Contributor
There was a problem hiding this comment.
What does cm stands for?
Contributor
Author
There was a problem hiding this comment.
cm = ClusterMetadata
Contributor
|
and yes, please add unit test. |
rodrigozhou
force-pushed
the
fix-add-search-attributes
branch
from
c82656c to
f35ae93
Compare
rodrigozhou
added a commit
that referenced
this pull request
May 13, 2023
rodrigozhou
added a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix adding multiple search attributes of same type at once.
Synched
AdminHandler's code to add search attributes.Added unit tests to operator handler.
Why?
#4160
When adding multiple search attributes of same type, it's missing a check to not use new mappings when trying to map a new search attribute. Eg: initially it maps
Key1toField1and thenKey2toField1again because it didn't check thatField1is unavailable afterKey1was mapped.How did you test it?
Added multiple search attributes with same type using Temporal CLI and
tctl.Added unit test.
Potential risks
No.
Is hotfix candidate?
No.