Make shard ownership more resilient when shard is busy #4283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
May 5, 2023
rodrigozhou
pushed a commit
that referenced
this pull request
May 13, 2023
* Do timeout check after shard lock acquired, not before
rodrigozhou
pushed a commit
that referenced
this pull request
May 16, 2023
* Do timeout check after shard lock acquired, not before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
When shard lock contention occurs, caller coroutine can wait a long time before acquiring shard lock, consequent IO operation may not have enough timeout left.
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
Yes