Save last RetryStatus for retryable failures #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Jun 5, 2020
Comment on lines
670
to
671
| // TODO(maxim): is decisionTaskCompletedID the correct id? | ||
| // TODO(maxim): should we introduce new TimeoutTypes (Workflow, Run) for workflows? |
Contributor
Author
There was a problem hiding this comment.
Should I remove this comment?
| break Loop | ||
| } | ||
|
|
||
| if timerSequenceID.timerType != timerTypeScheduleToStart { |
Contributor
Author
There was a problem hiding this comment.
I removed this check because RetryActivity below will call IsRetryable and it will return NonRetryableFailure for ScheduleToStart.
Comment on lines
+237
to
+238
| if retryStatus == commonpb.RetryStatus_Timeout { | ||
| timeoutFailure.GetTimeoutFailureInfo().TimeoutType = commonpb.TimeoutType_ScheduleToClose |
Contributor
Author
There was a problem hiding this comment.
This is how I change timeout type for timed out retries.
mfateev
approved these changes
Jun 5, 2020
Comment on lines
670
to
671
| // TODO(maxim): is decisionTaskCompletedID the correct id? | ||
| // TODO(maxim): should we introduce new TimeoutTypes (Workflow, Run) for workflows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
getBackoffIntevalbesides interval itself, now returns current retry status fromcommonpb.RetryStatusenum.Why?
RetryStatusis stored in history and can be used for debugging. It also allows to generate more accurate timeout errors.How did you test it?
All tests.
Potential risks
No risks.