Prefix enums with type and convert to upper case #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Jun 9, 2020
Makefile
Outdated
| @printf $(COLOR) "Install/update proto plugins..." | ||
| GO111MODULE=off go get -u github.com/gogo/protobuf/protoc-gen-gogofaster | ||
| GO111MODULE=off go get -u google.golang.org/grpc | ||
| (cd && go get -u github.com/temporalio/gogo-protobuf/protoc-gen-gogoslick) |
Contributor
Author
There was a problem hiding this comment.
This is our fork which generates short string enum representation (same as it was before).
| enum DLQType { | ||
| Replication = 0; | ||
| Namespace = 1; | ||
| enum DeadLetterQueueType { |
Contributor
Author
There was a problem hiding this comment.
Had to rename this type to make it work with CamelCase <-> SCREAMING_CASE conversion.
alexshtin
force-pushed
the
feature/enum-zero
branch
from
b477f25 to
088f27a
Compare
shawnhathaway
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Prefix enums with type and convert to upper case. Simple global replace w/o any logic change.
Why?
To match proto files, to match proto files guidelines.
How did you test it?
All tests.
Potential risks
No risks.