Skip to content

Conversation

@shawnhathaway
Copy link
Contributor

@shawnhathaway shawnhathaway commented Jun 11, 2020

What changed?

  • Parallelism Factor: 2 -> 10 and Join Size: 3 -> 1
    • This ensures we can join a two node cluster.
    • This will also help in the case that IP addresses are changing on restart to allow us to go through a larger number of candidates
  • Reduce heartbeat sleep interval and add jitter to prevent all nodes aligning (Heartbeat every 10-15 Seconds)
  • Heartbeat cutoff time for reading candidate seed nodes reduced to 20 seconds.

How did you test it?
Ringpop unit tests

Potential risks
This shouldn't add additional risk.

@shawnhathaway shawnhathaway requested a review from samarabbas June 15, 2020 18:04
@alexshtin alexshtin self-requested a review June 18, 2020 17:05
@shawnhathaway shawnhathaway merged commit 4ca4935 into temporalio:master Jun 29, 2020
@shawnhathaway shawnhathaway deleted the ringpop_params branch June 29, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants