Replace CLI options to accept enum names instead of integers #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
changed the title
feedmeapples
requested review from
alexshtin and
shawnhathaway
and removed request for
alexshtin
feedmeapples
changed the title
alexshtin
approved these changes
Jun 18, 2020
Contributor
alexshtin
left a comment
alexshtin
left a comment
There was a problem hiding this comment.
Please address comments and merge.
Co-authored-by: Alex Shtin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added util to map user CLI input to concrete enums. Replaced integer options to actual enum names.
Why?
In CLI, users can now type human friendly options instead of obscure integers. Example:
before:
-- workflowidreusepolicy 1after:
--workflowidreusepolicy AllowDuplicateFailedOnly(case-insensitive)If typed incorrectly, CLI will print out possible candidates.
How did you test it?
Ran tests and commands.
Potential risks
Low risk. Main inconvenience for some users will be having to re-learn the usage of affected CLI options.