Handle get namespace by id error #4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jun 29, 2023
service/history/queues/executable.go
Outdated
Comment on lines
212
to
215
| if e.state != ctasks.TaskStatePending { | ||
| e.Unlock() | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
can we move this part above the defer? don't think we need metrics for tasks that was cancelled. The lock is just for getting state & priority, and in one lock we can get and remember both values.
yycptt
reviewed
Jun 29, 2023
service/history/queues/executable.go
Outdated
|
|
||
| ns, err := e.namespaceRegistry.GetNamespaceByID(namespace.ID(e.GetNamespaceID())) | ||
| if err != nil { | ||
| return err |
Member
There was a problem hiding this comment.
need to populate e.taggedMetricsHandler by doing
e.taggedMetricsHandler = e.metricsHandler.WithTags(e.estimateTaskMetricTag()...)
same for L236
yux0
force-pushed
the
handle-ns-by-id-err
branch
from
3257f05 to
5480ded
Compare
yycptt
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Handle get namespace by id error
Why?
Handle get namespace by id error
How did you test it?
Potential risks
Is hotfix candidate?
Yes.