Skip to content

Conversation

@alexshtin
Copy link
Contributor

@alexshtin alexshtin commented Jun 28, 2020

What changed?
GOBIN variable value is added to PATH env variable.

Why?
Some users don't have default go bin directory in PATH variable. This leads to failure in proto compiler and other go tools. With this fix binaries will always be accessible. Fix is based on the doc:

The install directory is controlled by the GOPATH and GOBIN environment variables. If GOBIN is set, binaries are installed to that directory. If GOPATH is set, binaries are installed to the bin subdirectory of the first directory in the GOPATH list. Otherwise, binaries are installed to the bin subdirectory of the default GOPATH ($HOME/go or %USERPROFILE%\go).

How did you test it?
Run it locally.

Potential risks
No risks.

@alexshtin alexshtin requested review from markmark206 and mfateev June 28, 2020 06:31
@alexshtin alexshtin changed the title Add GOBIN to PATH in Makefile. Add GOBIN to PATH in Makefile Jun 28, 2020
@alexshtin alexshtin merged commit 6209190 into temporalio:master Jul 1, 2020
@alexshtin alexshtin deleted the feature/add-gobin-to-path branch July 1, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants