Remove cancel failed events for activity and timer #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
force-pushed
the
remove-cancel-failed-events
branch
from
8b376fb to
1e48da6
Compare
alexshtin
approved these changes
Jul 14, 2020
Contributor
alexshtin
left a comment
alexshtin
left a comment
There was a problem hiding this comment.
I would start from https://github.com/temporalio/api repo, remove enums from it first, and then update go.temporal.io/api here to make sure that those enums are not used anywhere else.
mfateev
approved these changes
Jul 15, 2020
Whenever workflow worker makes a cancel decision, requestCancelActivity in the case of an activity and cancelTimer in the case of timer we no longer fail the individual decision if we cannot find the activity or timer to cancel. This means sdk code has a bug which resulted in client code to be able to make cancellation decision in the first place. We should be failing the entire decision like we do in all other places. RequestCancelActivityTaskFailed was already removed in PR temporalio#355, so this PR removes the unused EVENT_TYPE_REQUEST_CANCEL_ACTIVITY_TASK_FAILED enum. Removing all logic which results in CancelTimerFailed event in the history when TimerCancel decision is made and instead fail the entire decision.
samarabbas
force-pushed
the
remove-cancel-failed-events
branch
from
1e48da6 to
c458516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
RequestCancelActivityTaskFailed was already removed in PR #355, so
this PR removes the unused EVENT_TYPE_REQUEST_CANCEL_ACTIVITY_TASK_FAILED
enum.
Removing all logic which results in CancelTimerFailed event in the
history when TimerCancel decision is made and instead fail the
entire decision.
Why?
Whenever workflow worker makes a cancel decision, requestCancelActivity
in the case of an activity and cancelTimer in the case of timer we
no longer fail the individual decision if we cannot find the activity
or timer to cancel. This means sdk code has a bug which resulted in
client code to be able to make cancellation decision in the first
place. We should be failing the entire decision like we do in all
other places.
How did you test it?
Unit and Integration Tests
Potential risks
No risk