Fix Querying archived workflows not recognizing terminated workflows #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jul 14, 2020
samarabbas
approved these changes
Jul 14, 2020
Contributor
samarabbas
left a comment
samarabbas
left a comment
There was a problem hiding this comment.
Can you also add a test to make sure we don't break this in the future?
Contributor
Author
added this and few more missing tests around query parsing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Querying for archived workflows with a "terminated" status as a value should now work
Why?
It was throwing an error
unknown workflow close status: terminatedHow did you test it?
Executed a query with "terminated" status. Ran tests
Potential risks
No new risks