Skip to content

Conversation

@alexshtin
Copy link
Contributor

What changed?
Use payloads.ToString to print payload content.

Why?
CLI output is broken if payload is not of type string.

How did you test it?
Run tests.

Potential risks
No risks.

@alexshtin alexshtin requested a review from mastermanu July 14, 2020 17:36
@feedmeapples
Copy link
Contributor

Could you also check whether #413 is addressed with this change
cc @alexshtin @cullywakelin

@feedmeapples feedmeapples changed the title Use ToString for CLI output Fix processing cli Query command output Jul 14, 2020
@feedmeapples feedmeapples changed the title Fix processing cli Query command output Fix printing Query cli command results Jul 14, 2020
@alexshtin alexshtin changed the title Fix printing Query cli command results Fix printing Query CLI command results Jul 14, 2020
@alexshtin alexshtin merged commit 0eafe04 into temporalio:master Jul 14, 2020
@alexshtin alexshtin deleted the feature/use-tostring branch July 14, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants