Removing references to graphite in docker/README #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
markmark206
approved these changes
Jul 16, 2020
markmark206
approved these changes
Jul 16, 2020
alexshtin
changed the title
alexshtin
reviewed
Jul 16, 2020
alexshtin
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
References to graphite, localhost:8080, and statsd have been removed from the docker README.
Why?
The references were removed because graphite and statsd are no longer components and dependencies by default. When running temporal via
docker-compose up, there is no metrics dashboard available as the document currently claims or a dependency on statsd.How did you test it?
This is just a change to the README text.
Potential risks
There should be no risk with this change.