Change default order for listClosedWorkflowExecutions to by close time #312 #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermanu
requested review from
mfateev,
samarabbas and
shawnhathaway
and removed request for
mfateev
…listclosedworkflowexecutions_order
…rmanu/temporal into listclosedworkflowexecutions_order
mastermanu
commented
Jul 17, 2020
| CREATE INDEX closed_by_status ON closed_executions (status); | ||
|
|
||
| -- same as closed_executions but order by close_time | ||
| CREATE TABLE closed_executions_v2 ( |
Member
Author
There was a problem hiding this comment.
@samarabbas @shawnhathaway - I can also remove the v2 suffix here if you think that makes sense
Contributor
There was a problem hiding this comment.
Yea, given v1 is being removed, this would make sense. We have done this in other places.
…listclosedworkflowexecutions_order
shawnhathaway
approved these changes
Jul 20, 2020
| CREATE INDEX closed_by_status ON closed_executions (status); | ||
|
|
||
| -- same as closed_executions but order by close_time | ||
| CREATE TABLE closed_executions_v2 ( |
Contributor
There was a problem hiding this comment.
Yea, given v1 is being removed, this would make sense. We have done this in other places.
…listclosedworkflowexecutions_order
…rmanu/temporal into listclosedworkflowexecutions_order
…listclosedworkflowexecutions_order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes:
- The option to switch between V1 and V2 Persistence Visibility stores (V1 was the default)
- The V2 Cassandra Persistence Visibility Store (merged it with the V1 store).
- The V1 tables in Cassandra itself
As a result, running tctl wf list now returns closed workflows ordered by their closed time in a descending order as mentioned in this issue: #312
Tested locally with unit tests and confirmed tctl returns in the expected order