Timeout workflow when WorkflowExecutionTimeout is reached #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
reviewed
Jul 18, 2020
common/backoff/cron.go
Outdated
| return NoBackoff | ||
| } | ||
|
|
||
| if closeTime.Before(startTime) { |
Contributor
There was a problem hiding this comment.
I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately.
samarabbas
requested changes
Jul 18, 2020
Contributor
samarabbas
left a comment
samarabbas
left a comment
There was a problem hiding this comment.
Changes in timerQueueActiveTaskExecutor.go looks good. But you need to slightly adjust the logic in GetBackoffNextSchedule based on the comment I left.
alexshtin
force-pushed
the
fix/workflow-timeout
branch
from
0abb1c2 to
e1b6c44
Compare
samarabbas
approved these changes
Jul 20, 2020
This was referenced Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
If
WorkflowExecutionTimeoutis reached on workflow, workflow is timed out in spite of cron schedule.Also fix
GetBackoffForNextScheduleto return right result ifcloseTimeis beforestartTime.Why?
Fixing bugs discovered in #394.
How did you test it?
Added new unit tests.
Potential risks
No risks.