Allow for es scheme (https, http) to be configurable via container's env var #563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This is a change for #562. With this change, temporal container can be configuring to use a scheme other than http (such as https;) to connect to elastic search.
This change goes along with temporalio/helm-charts#49
Why?
A customer reported that this is the behavior they would expect, but that was not the actual behavior.
How did you test it?
I built the docker image and deployed it to a k8s cluster, using temporal helm chart (temporalio/helm-charts#49), passing in "ES_SCHEME: https" env var. I made sure the env var took effect (I didn't have an ES listening on HTTPS port so the connection failed to esablish, as expected).
I also tested with "ES_SCHEME: https" and made sure things continue to work.
Potential risks
Elastic search connectivity might become broken.