Fixes flaky ContinueAsNewWorkflow_Timeout integration test #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test had a race condition where a workflow could timeout between WorkflowTask being scheduled and calling PollForWorkflowTask. This resulted in test getting in a stuck state as underlying implementation for PollForWorkflowTask would retry for a long time if it receives empty polls. Fixed the race condition by moving the sleep after PollForWorkflowTask and also removed retry logic on empty polls.
samarabbas
force-pushed
the
continue-as-new-flaky-test
branch
from
cb5f1f0 to
4750b94
Compare
alexshtin
changed the title
alexshtin
approved these changes
Jul 20, 2020
samarabbas
force-pushed
the
continue-as-new-flaky-test
branch
from
b42cc49 to
0695340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed the race condition by moving the sleep after
PollForWorkflowTaskand also removed retry logic on empty polls.Why?
Test had a race condition where a workflow could timeout between WorkflowTask being scheduled and calling
PollForWorkflowTask. This resulted in test getting in a stuck state as underlying implementation forPollForWorkflowTaskwould retry for a long time if it receives empty polls.Fixed #497.
How did you test it?
Running integration tests.
Potential risks
No risk.