-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Disable Archival feature in development docker #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
samarabbas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to also update config_template.yaml used by docker builds:
https://github.com/temporalio/temporal/blob/master/docker/config_template.yaml
| policy: "noop" | ||
| toDC: "" | ||
|
|
||
| archival: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious – were you able to start temporal server using this config file? if not, i wonder if it is worth it to postpone adding development_archival.yaml until we release tested/supported archival feature and have a chance to really test this. (not a blocker for this merge, of course, just thinking out loud).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markmark206 this configuration is the same as the previous development.yaml which had archival enabled and that we've been running. Should we do a separate testing of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we talked about testing all config files at some point, but until then, just running ./temporal-server -e development_archival start would be enough. (since this is a copy paste of another file, it's likely it just works, and it's not breaking any workflows, so i think this is also fine as is.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| archival: | ||
| history: | ||
| state: "enabled" | ||
| state: "disabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you file a separate issue to make this docker parameter which users can control?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a ticket #623 Add control of archival feature initial state through docker-compose parameter.
Does this mean that the variable will override the archival state set in defaultNamespace of temporal config?

What changed?
development-*.yamldocker configs now set archival feature to "disabled" by default.Added
development_archival.yamlthat has archival "enabled"Why?
File based implementation of archival feature may not be the best to be enabled by default as it can bloat up the storage.
How did you test it?
docker build -t temporalio/server:test .docker-compose uptctl namespace desribePotential risks
No risks